update flannel v0.24.2 #5071
update flannel v0.24.2 #5071
Conversation
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5071-e9a7449-flannel-0.24.2-k8s-ctrd-2024-02-09T19:20:22Z |
|
I don't want this to become bigger and bigger but shouldn't we be also shipping the ethtool host package if we are using it ? |
|
Possibly, but also any server that needs this change (running in vmware with virtualization packages) probably already has it |
|
I created #5076 because I had to add some fixes to my code, and I don't have push access to replicatedhq/kURL repo |
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5071-2699706-flannel-0.24.2-k8s-ctrd-2024-03-08T17:02:11Z |
|
@laverya ready for review again, thanks! |
|
Testgrid Run(s) Executing @ https://testgrid.kurl.sh/run/pr-5071-994473b-flannel-0.24.2-k8s-ctrd-2024-03-08T17:27:57Z |
What this PR does / why we need it:
Adds a systemd drop-in to disable TCP checksum offloading for VMware VMXNET3 NIC drivers - this is defaulted to ON in modern Linux kernels, but in certain VMWare deployments, the checksum offloading is handled incorrectly leading to dropped packets on the interface. Detecting it is difficult because it only manifests in multi-node configurations once additional nodes have been added, but host networking works just fine so kURL does not detect a problem at installation time. Disabling this for all VMXNET3 driver users seems like a safe assumption and disabling TCP checksum offloading incurs very little performance penalty.
The
ethtoolcommand can be used to fix the problem in-situ but changes made with that tool are not persistent, so this systemd unit hooks into the flannel device unit file and disables the offloading option whenever the flannel interface is configured.Researching the issue
See also
Which issue(s) this PR fixes:
Fixes https://app.shortcut.com/replicated/story/91846/hostpreflight-detect-if-host-nic-uses-vmxnet3-driver-from-vmware-and-if-so-warn-about-vxlan-checksum-offloading
Special notes for your reviewer:
Steps to reproduce
Does this PR introduce a user-facing change?
Does this PR require documentation?
NONE